Skip to content

added default sort order to dataGrid#2987

Merged
chandlerprall merged 4 commits intoelastic:masterfrom
anishagg17:default
Mar 6, 2020
Merged

added default sort order to dataGrid#2987
chandlerprall merged 4 commits intoelastic:masterfrom
anishagg17:default

Conversation

@anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 5, 2020 •
edited
Loading

Summary

Fixes : #2974
added default sort order to dataGrid

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

kibanamachine commented Mar 5, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 5, 2020

@myasonik @chandlerprall I have added default 'desc' property to version and date column
and default 'asc' property to name field

if no default is supplied as a prop 'asc' sorting would be performed

@chandlerprall chandlerprall self-requested a review March 6, 2020 19:10
@chandlerprall chandlerprall self-assigned this Mar 6, 2020
chandlerprall
chandlerprall suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes requested, also: we'll want to add a defaultSortDirection prop on EuiDataGridSchemaDetector which should be used if the value isn't overridden by a column.

Loosely, initialSortDirection = column.defaultSortDirection || columnSchema.defaultSortDirection || 'asc'

@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 6, 2020

@chandlerprall changes have been made

chandlerprall
chandlerprall approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Pulled and tested locally

@chandlerprall
Copy link
Contributor

chandlerprall commented Mar 6, 2020

jenkins test this

@kibanamachine
Copy link

kibanamachine commented Mar 6, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_2987/

@chandlerprall chandlerprall merged commit 9a52f2f into elastic:master Mar 6, 2020
@chandlerprall chandlerprall mentioned this pull request Mar 16, 2020
Merged
@anishagg17 anishagg17 deleted the default branch March 21, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chandlerprall chandlerprall

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataGrid should allow for a default sort order

3 participants

@anishagg17 @kibanamachine @chandlerprall